various CI improvements #501
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
- Coverage 62.71% 56.61% -6.11%
==========================================
Files 29 29
Lines 2229 2222 -7
==========================================
- Hits 1398 1258 -140
- Misses 831 964 +133 ☔ View full report in Codecov by Sentry. |
|
@thazhemadam do you know what the issue is here? |
|
I'll need some help fixing this deprecation: https://github.com/SciML/LinearSolve.jl/actions/runs/9061500275/job/24893376530?pr=501#step:6:2073 |
|
@fredrikekre "LoadError: mpiexec() is deprecated, use the non-do-block form" do you know the fix here? |
diff --git a/test/hypretests.jl b/test/hypretests.jl
index c41079c1..da7e7e3a 100644
--- a/test/hypretests.jl
+++ b/test/hypretests.jl
@@ -168,7 +168,5 @@ test_interface(HYPREAlgorithm(HYPRE.PCG(comm)), Pl = HYPRE.BoomerAMG())
# Test MPI execution
mpitestfile = joinpath(@__DIR__, "hypretests_mpi.jl")
-mpiexec() do mpi
- r = run(ignorestatus(`$(mpi) -n 2 $(Base.julia_cmd()) $(mpitestfile)`))
- @test r.exitcode == 0
-end
+r = run(ignorestatus(`$(mpiexec()) -n 2 $(Base.julia_cmd()) $(mpitestfile)`))
+@test r.exitcode == 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.